<html>
<head><meta charset="utf-8"><title>allow() failing? · clippy · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/index.html">clippy</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/allow().20failing.3F.html">allow() failing?</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="225600563"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/allow%28%29%20failing%3F/near/225600563" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Dirkjan Ochtman <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/allow().20failing.3F.html#225600563">(Feb 08 2021 at 20:10)</a>:</h4>
<p>Can anyone help me make sense of the failure to allow <code>from_over_into</code> here? <a href="https://github.com/open-telemetry/opentelemetry-rust/pull/453/checks?check_run_id=1856625434">https://github.com/open-telemetry/opentelemetry-rust/pull/453/checks?check_run_id=1856625434</a></p>



<a name="225608650"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/allow%28%29%20failing%3F/near/225608650" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Cameron Steffen <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/allow().20failing.3F.html#225608650">(Feb 08 2021 at 21:09)</a>:</h4>
<p>where is the rust/cargo/clippy version set?</p>



<a name="225608691"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/allow%28%29%20failing%3F/near/225608691" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Cameron Steffen <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/allow().20failing.3F.html#225608691">(Feb 08 2021 at 21:09)</a>:</h4>
<p><a href="https://github.com/open-telemetry/opentelemetry-rust/blob/main/.github/workflows/ci.yml#L51">https://github.com/open-telemetry/opentelemetry-rust/blob/main/.github/workflows/ci.yml#L51</a><br>
this looks suspicious</p>



<a name="225660857"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/allow%28%29%20failing%3F/near/225660857" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Dirkjan Ochtman <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/allow().20failing.3F.html#225660857">(Feb 09 2021 at 09:09)</a>:</h4>
<p>That's the msrv job, which doesn't run clippy</p>



<a name="225661361"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/allow%28%29%20failing%3F/near/225661361" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Dirkjan Ochtman <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/allow().20failing.3F.html#225661361">(Feb 09 2021 at 09:14)</a>:</h4>
<p>It looks like that lint is from nightly clippy, which would explain the problem here</p>



<a name="225661373"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/allow%28%29%20failing%3F/near/225661373" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Dirkjan Ochtman <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/allow().20failing.3F.html#225661373">(Feb 09 2021 at 09:14)</a>:</h4>
<p>Must have missed that</p>



<a name="225661451"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/allow%28%29%20failing%3F/near/225661451" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/allow().20failing.3F.html#225661451">(Feb 09 2021 at 09:15)</a>:</h4>
<p>I mean, 1.46 doesn't have the <code>from_over_into</code> lint. So if you try to allow it, Clippy (and in future rustc)  will complain, that this lint doesn't exist.</p>



<a name="225662348"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/allow%28%29%20failing%3F/near/225662348" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Dirkjan Ochtman <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/allow().20failing.3F.html#225662348">(Feb 09 2021 at 09:25)</a>:</h4>
<p>Yeah, I'll just fix them up</p>



<a name="225662373"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/allow%28%29%20failing%3F/near/225662373" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Dirkjan Ochtman <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/allow().20failing.3F.html#225662373">(Feb 09 2021 at 09:25)</a>:</h4>
<p>also got confused about the dead_code false positives on current nightly</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>